Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More syncthing options #136090

Merged
merged 2 commits into from
Aug 29, 2021
Merged

More syncthing options #136090

merged 2 commits into from
Aug 29, 2021

Conversation

jakubgs
Copy link
Contributor

@jakubgs jakubgs commented Aug 29, 2021

Motivation for this change

The addition of autoAcceptFolders avoids the prompts for each folder when adding a devices.

The extraFlags option is useful for situations in which you might want to reset certain things using --reset-database or --reset-deltas or debug certain things using any of the debug options like --debug-perf-stats.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ncfavier
Copy link
Member

Rebased against the wrong branch?

nixos/modules/services/networking/syncthing.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/syncthing.nix Outdated Show resolved Hide resolved
@ncfavier
Copy link
Member

@ofborg test syncthing syncthing-init

Signed-off-by: Jakub Sokołowski <jakub@status.im>
This is useful for situations in which you might want to reset certain
things using `--reset-database` or `--reset-deltas` or debug certain
things using any of the debug options like `--debug-perf-stats`.

Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs
Copy link
Contributor Author

jakubgs commented Aug 29, 2021

Thanks for the review @ncfavier. Cute waifu.

@Lassulus Lassulus merged commit 4a57860 into NixOS:master Aug 29, 2021
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-use-service-definitions-from-unstable-channel/14767/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants